godot-escoria / escoria-issues

Central Escoria issue tracker
3 stars 0 forks source link

Room 12 left door has broken #296

Closed balloonpopper closed 2 years ago

balloonpopper commented 2 years ago

Describe the bug One of the recent changes has broken room 12. When you try to use the left door the debug says that the destination point couldn't be reached so no action will run. A quick test of moving the associated ESClocation into the middle of the walkable floor results in the same problem - he walks to the ESClocation but doesn't do anything.

To Reproduce Run room 12 directly Try to use the left door

Expected behavior Room 11 should load

Screenshots If applicable, add screenshots to help explain your problem.

Versions

Additional context Add any other context about the problem here.

BHSDuncan commented 2 years ago

This is well and truly strange. This only happens with Godot 3.5!

if not player_global_pos.is_equal_approx(destination_position):

It appears as though player_global_pos, prior to 3.5, had the same value as destination_position, but in 3.5, it looks to be using something a bit off (off by like... 0.001 or 0.01). Looking into what's different in 3.5...

BHSDuncan commented 2 years ago

It looks like the soon-to-be-deprecated Navigation2D class has changed something with its get_simple_path() method. :( I don't know how we can easily fix this unless we hack something in...