godot-escoria / escoria-issues

Central Escoria issue tracker
3 stars 0 forks source link

Simplemouse tooltip takes too long to disappear #353

Open balloonpopper opened 1 year ago

balloonpopper commented 1 year ago

Please make sure you talk to the community before creating an issue.

Describe the bug When you combine two items, the graphic tooltip doesn't disappear until after the player's script executes.

To Reproduce Steps to reproduce the behavior: Run room 5. Combine the pen and paper. I would like the pen icon to disappear as soon as you click it on the paper - instead it stays active while the player speaks.

Expected behavior The graphic tooltip clears immediately when you use the item on something else. We'd need to discuss whether we think it should stay active if the "use" action fails.

Screenshots If applicable, add screenshots to help explain your problem.

Versions

Additional context Add any other context about the problem here.

BHSDuncan commented 1 year ago

I'd argue this is a matter of personal taste and less a bug. To that end, we should probably look at adding additional signals to mark parts of the action/event lifecycle.

balloonpopper commented 1 year ago

I consider it a bug in the same way as if you click someone to have a conversation you don't expect the tooltip to still say their name, regardless of whether they were highlighted, until the conversation finishes.

StraToN commented 1 year ago

Should be fixed by commit 751e44dad8c1462c38c7d74799b30ec94865103e