search

godot-extended-libraries / godot-debug-menu

Display in-game FPS/performance/hardware metrics in a Godot 4.x project
https://github.com/godot-extended-libraries/godot-debug-menu-demo
MIT License
429 stars 16 forks source link

Added `z_index`to the DebugMenu scene. Closes #6 #7

Closed yunylz closed 1 year ago

yunylz commented 1 year ago

Added z_index and set it to max value in _init() so that the menu does not go under the current scene

Calinou commented 1 year ago

Why not set the property in the debug_menu.tscn scene in the inspector? Is there a reason it has to be set in _init()?

yunylz commented 1 year ago

Well, you can do that too, I thought it would be easier this way instead of having new people adjust that manually.

Calinou commented 1 year ago

Well, you can do that too, I thought it would be easier this way instead of having new people adjust that manually.

It can be done in the autoloaded scene so people don't have to adjust it manually :slightly_smiling_face:

I'm referring to addons/debug_menu/debug_menu.tscn, that is.

Calinou commented 1 year ago

Superseded by https://github.com/godot-extended-libraries/godot-debug-menu/commit/2d1bf27e5901186080e0fde5adc56df65dd9c583, which also fixes the issue with Camera2D nodes making the debug menu appear offset. The demo project has been modified to demonstrate this use case.

Thanks for the contribution nonetheless!