Removed cyclic Array2D references

godot-extended-libraries / godot-next

Godot Node Extensions - Basic Node Extensions for Godot Engine

MIT License

957 stars 61 forks source link

Removed cyclic Array2D references #70

Closed Rubonnek closed 4 years ago

Rubonnek commented 4 years ago

Having references to class_name when extending Reference within the same script causes object leaks. The PropertyInfo class also suffers from the same issue -- I'm working on having a PropertyInfoFactory to create PropertyInfo objects.

I reworked Array2D so that the object leaks don't happen -- the modified functions will modify the original object by default.

Rubonnek commented 4 years ago

Oh.... I see what's happening now with the duplicate functionality.

Internal arrays must also be duplicated.

Rubonnek commented 4 years ago

This PR is reviewable now.

willnationsdev commented 4 years ago

Thanks!