Removed cyclic PropertyInfo references and added PropertyInfoFactory

godot-extended-libraries / godot-next

Godot Node Extensions - Basic Node Extensions for Godot Engine

MIT License

957 stars 61 forks source link

Removed cyclic PropertyInfo references and added PropertyInfoFactory #72

Closed Rubonnek closed 4 years ago

Rubonnek commented 4 years ago

Not sure if this is wanted, but I'd rather avoid using a SELF_PATH constant which locks down the path for the script.

This patch also avoid an object leak on PropertyInfo, but that could also be fixed by changing PropertyInfo string ocurrences to Reference except on class_name.

willnationsdev commented 4 years ago

Looks good to me. The Factory bit makes the intent a bit more clear anyway, and helps to declutter the PropertyInfo class. Thanks!