Closed nonunknown closed 3 years ago
@nonunknown Okay, this is looking pretty good. Sorry it took me so long to give this the light of day. Just a few quick things.
- can you either remove the print statement or make it an optional setting? The default behavior of a node shouldn't print a message without users being able to turn it off.
- can you make the deferred calls optional, so that the target node isn't required to implement each of the methods? Just preface each call with an
if target.has_method(...):
Once those are resolved, I'll merge it.
1 - about the first one yeah, I can do 2 - the defered one doesnt need to check if the function exists, if it doesnt exists, the engine doesnt call, neither throw any message
@nonunknown
2 - the defered one doesnt need to check if the function exists, if it doesnt exists, the engine doesnt call, neither throw any message
Ah, gotcha. Sounds good. Can you remove the extra spacing in your script so that the file format check passes?
@nonunknown Okay, this is looking pretty good. Sorry it took me so long to give this the light of day. Just a few quick things.
if target.has_method(...):
Once those are resolved, I'll merge it.