search

godot-rust / gdnative

Rust bindings for Godot 3
https://godot-rust.github.io
MIT License
3.61k stars 210 forks source link

Update bitflags requirement from 1 to 2 #1041

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Updates the requirements on bitflags to permit the latest version.

Release notes

Sourced from bitflags's releases.

2.0.0

What's Changed

New Contributors

Full Changelog: https://github.com/bitflags/bitflags/compare/1.3.2...2.0.0

Changelog

Sourced from bitflags's changelog.

2.0.0

What's Changed

New Contributors

Full Changelog: https://github.com/bitflags/bitflags/compare/1.3.2...2.0.0

2.0.0-rc.3

What's Changed

... (truncated)

Commits


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
chitoyuu commented 1 year ago

Careful with merging: we expose a bitflags-generated type publicly: PropertyUsage.

bors try

bors[bot] commented 1 year ago

try

Build failed:

chitoyuu commented 1 year ago

Apparently this update breaks Copy which is a deal breaker. It might be good to look into the details, but bitflags v1 has been working perfectly fine for a long time, and none of the updates seem to be really crucial (from a user perspective) at a glance.

For now, let's skip this update and stay on v1, until there's a convincing use case for v2.

@dependabot ignore this major version

dependabot[bot] commented 1 year ago

OK, I won't notify you about version 2.x.x again, unless you re-open this PR. 😢