godot-rust / gdnative

Rust bindings for Godot 3
https://godot-rust.github.io
MIT License
3.61k stars 210 forks source link

Outdated GDNative API: `determinant` method in Transform2D is not implemented #1048

Closed necrashter closed 1 year ago

necrashter commented 1 year ago

With this commit, determinant method was added to Transform2D. However, it's not implemented in this repository yet. Therefore, using the latest build of Godot engine from 3.x branch causes a crash with the following backtrace:

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v3.6.beta.custom_build (c4becb0ca44de25ee9ca9a3365245d979dad1e61)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7fbe24e42520] (??:0)
[2] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0x31cdf63] (/home/ilker/Programming/godot/godot/./core/cowdata.h:128)
[3] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0x31ce2a5] (/home/ilker/Programming/godot/godot/./core/cowdata.h:376)
[4] godot::GlobalConstants::___init_method_bindings() (??:0)
[5] godot::___init_method_bindings() (??:0)
[6] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xf90da7] (/home/ilker/Programming/godot/godot/modules/gdnative/gdnative.h:88)
[7] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xb60eb4] (/home/ilker/Programming/godot/godot/modules/gdnative/register_types.cpp:304)
[8] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xb61e9a] (/home/ilker/Programming/godot/godot/modules/register_module_types.gen.cpp:93)
[9] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xa7112a] (/home/ilker/Programming/godot/godot/main/main.cpp:1588)
[10] /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7fbe24e29d90] (??:0)
[11] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80) [0x7fbe24e29e40] (??:0)
[12] /home/ilker/Programming/godot/godot/bin/godot.x11.opt.tools.64() [0xa7e305] (??:?)
-- END OF BACKTRACE --
================================================================
necrashter commented 1 year ago

This issue has been fixed by this merged PR on Godot which moves Transform2D::determinant to the newly added Core API 1.4.

Thanks to Bromeon and chitoyuu for helping me debug this issue on Discord and thanks to akien-mga for PR!