search

godot-rust / gdnative

Rust bindings for Godot 3
https://godot-rust.github.io
MIT License
3.61k stars 210 forks source link

Update bindgen requirement from 0.65.1 to 0.66.0 #1050

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Updates the requirements on bindgen to permit the latest version.

Release notes

Sourced from bindgen's releases.

v0.66.0

See the changelog for further information.

Changelog

Sourced from bindgen's changelog.

0.66.0

Added

  • Added the --generate-cstr CLI flag to generate string constants as &CStr instead of &[u8]. (Requires Rust 1.59 or higher.)
  • Added the --generate-shell-completions CLI flag to generate completions for different shells.
  • The --wrap-static-fns option can now wrap va_list functions as variadic functions with the experimental ParseCallbacks::wrap_as_variadic_fn method.
  • Add target mappings for riscv32imc and riscv32imac.
  • Add the ParseCallbacks::field_visibility method to modify field visibility.

Changed

  • Non-UTF-8 string constants are now generated as references (&[u8; SIZE]) instead of arrays ([u8; SIZE]) to match UTF-8 strings.
  • Wrappers for static functions that return void no longer contain a return statement and only call the static function instead.
  • The --wrap-static-fns option no longer emits wrappers for static variadic functions.
  • Depfiles generated with --depfile or Builder::depfile will now properly generate module names and paths that include spaces by escaping them. To make the escaping clear and consistent, backslashes are also escaped.
  • Updated bitflags dependency to 2.2.1. This changes the API of CodegenConfig.
  • Prettyplease formatting is gated by an optional, enabled by default Cargo feature when depending on bindgen as a library.
  • Items are now parsed in the order they appear in source files. This may result in auto-generated _bindgen_* names having a different index.
  • Use default visibility for padding fields: Previously, padding fields were always public. Now, they follow the default visibility for the type they are in.
  • Compute visibility of bitfield unit based on actual field visibility: A bitfield unit field and its related functions now have their visibility determined based on the most private between the default visibility and the actual visibility of the bitfields within the unit.

Removed

  • Remove redundant Cargo features, which were all implicit:

    • bindgen-cli: env_logger and log removed in favor of logging
    • bindgen (lib):
      • log removed in favor of logging
      • which removed in favor of which-logging
      • annotate-snippets removed in favor of experimental

  • Prettyplease is available as a Formatter variant now.

0.65.1

Fixed

... (truncated)

Commits


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
GodotRust commented 1 year ago

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdnative/pr-1050

Bromeon commented 1 year ago

bors try

bors[bot] commented 1 year ago

try

Build failed:

Bromeon commented 1 year ago

Failure likely unrelated to this update; might be broken on master.

chitoyuu commented 1 year ago

The nightly clippy fail is unrelated, but shouldn't block the build. There's an iOS fail down below though that might be a spurious error on crates' side?

 [2023-06-15T06:03:32Z ERROR cargo_dinghy] failed to select a version for the requirement `bindgen = "^0.66.0"`
    candidate versions found which didn't match: 0.65.1, 0.64.0, 0.63.0, ...
    location searched: crates.io index
    required by package `gdnative-sys v0.11.3 (/Users/runner/work/gdnative/gdnative/gdnative-sys)`

Let's try again first.

bors try

bors[bot] commented 1 year ago

try

Build failed:

chitoyuu commented 1 year ago

This is bizarre. Apparently the 0.66.0 version (still) does not exist for the iOS target according to cargo_dinghy. Could this be a caching problem?

chitoyuu commented 1 year ago

While I'm not sure why this is happening, I don't believe anything from the bindgen update is strictly necessary either. The current version works just fine for us -- and is available for iOS. As such, I think it's reasonable to skip this update until any upstream issues (presumably) are resolved.

@dependabot ignore this minor version

dependabot[bot] commented 1 year ago

OK, I won't notify you about version 0.66.x again, unless you re-open this PR. 😢

chitoyuu commented 1 year ago

And I'll also try this one again.

@dependabot reopen

bors r+

bors[bot] commented 1 year ago

Already running a review

chitoyuu commented 1 year ago

bors r+

GodotRust commented 1 year ago

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdnative/pr-1050

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.