Closed dependabot[bot] closed 4 months ago
I thought this would be a not-too-hard change as advertised in the 2.0.0 release notes:
This release contains a batch of syntax tree improvements to incorporate ongoing Rust language development from the past 3.5 years since syn 1.
However, there's a ton of breaking changes, once you scroll down a bit. It also seems like gdnative is affected to a massive degree due to its heavy proc-macro use. I'm not sure if the upgrade is worth it just to stick to the ecosystem -- I would suggest we don't do it unless there are certain syn 2
features that we desperately need, or someone wants to dedicate the time to go through everything.
I agree. syn
can't cause semver conflicts in downstream crates unlike normal dependencies, because it's only linked into the proc-macro binary. Since the current implementation is still working well, there isn't really a reason to update "just to stick to the ecosystem", as you've said.
There's a possibility that at some point in the future, some fundamentally new syntax might be added that syn 1
can't handle, and update would become necessary, but I think that should be handled after the fact, if it happens and use cases exist for them together with gdnative
.
Since there seems to be an agreement:
@dependabot ignore this major version
OK, I won't notify you about version 2.x.x again, unless you re-open this PR.
Updates the requirements on syn to permit the latest version.
Release notes
Sourced from syn's releases.
Commits
81adad6
Release 2.0.587247053
Merge pull request #1611 from dtolnay/customdollar990142f
Support '$' in custom_punctuation macro4753622
Merge pull request #1610 from dtolnay/sortpunct36a7f67
Sort tokens in the same order between custom_punctuation_len and Token macrof104427
Update test suite to nightly-2024-03-319cea040
Release 2.0.573c07b78
Release 2.0.56585df47
Merge pull request #1608 from BD103/deps-featuresd7650b2
chore: bump msrv to 1.60 (pt. 2)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show