godot-rust / gdnative

Rust bindings for Godot 3
https://godot-rust.github.io
MIT License
3.62k stars 210 forks source link

Fixed ToVariant/FromVariant derive for generic types with bounds #961

Closed Bromeon closed 2 years ago

Bromeon commented 2 years ago

Fixes part of #957; but there's a separate problem with where clauses (see description).

bors[bot] commented 2 years ago

try

Build succeeded:

Bromeon commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Build failed:

Bromeon commented 2 years ago

Great, clippy stable conflicts with clippy nightly. Real good experience there 🙄 clippy nightly causes so much extra maintenance effort that I'm seriously thinking of ditching that CI job...

I'll revert the 2nd commit.

Bromeon commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Build succeeded:

Bromeon commented 2 years ago

I'll merge this so the remaining problems (where clause) can be fixed in a separate PR.

bors r+

bors[bot] commented 2 years ago

Build succeeded: