search

godot-sdk-integrations / godot-google-play-billing

Godot Android plugin for the Google Play Billing library
MIT License
156 stars 50 forks source link

Initial project commit #1

Closed timoschwarzer closed 4 years ago

timoschwarzer commented 4 years ago

Changes from the in-tree version:

akien-mga commented 4 years ago

I think it might have been nice Git history-wise to import the code as it was in godotengine/godot in a first commit, then do the other changes outlined above. But it's probably not a big deal :)

timoschwarzer commented 4 years ago

@m4gr3d

you also need to add the matching .gdap file for the repo to be complete

Done.

Will the README be updated in a separate pull request?

I can edit the README to contain a quick install guide, links to the docs (which I have to edit for this, too) and build instructions. Anything else in mind? :)

timoschwarzer commented 4 years ago

@m4gr3d @akien-mga general question: can/will/should this plugin be delivered via the Asset Library or does it need to be installed manually?

m4gr3d commented 4 years ago

I can edit the README to contain a quick install guide, links to the docs (which I have to edit for this, too) and build instructions. Anything else in mind? :)

Nope, that sounds good!

m4gr3d commented 4 years ago

@m4gr3d @akien-mga general question: can/will/should this plugin be delivered via the Asset Library or does it need to be installed manually?

The asset library hasn't yet been updated for the .gdap Android plugins, so at first the install process will be manual until it's. We'll need to use the repo releases section, and provide a versioned .aar file and its matching .gdap config file.

timoschwarzer commented 4 years ago

@akien-mga I'd prefer to keep the README rather short and link to the docs for extended API docs to prevent duplicate information. Can you merge https://github.com/godotengine/godot-docs/pull/3696? :)

akien-mga commented 4 years ago

Done! The page will only be on latest for now, but I'll sync the 3.2/stable branches with master tomorrow to have up to date docs for 3.2.2.

akien-mga commented 4 years ago

@timoschwarzer When you're available, could you PR the removal of the built-in library in godotengine/godot? So that it's not included in my upcoming 3.2.2 RC 3 build (which should be the same as 3.2.2-stable in a day or two if all goes well).

timoschwarzer commented 4 years ago

@akien-mga

3.2: https://github.com/godotengine/godot/pull/39744 master: https://github.com/godotengine/godot/pull/39745