search

godot-sdk-integrations / godot-google-play-billing

Godot Android plugin for the Google Play Billing library
MIT License
160 stars 50 forks source link

Updating plugin to PBL v4 #26

Closed natetrost closed 2 years ago

natetrost commented 3 years ago

1.0.1 uses the older version 3.0 of Play Billing Library plugin. The current version is 4.0.

A PR to update the plugin to 4.0, incorporating API changes and adding some missing feature coverage is here: https://github.com/godotengine/godot-google-play-billing/pull/25

A PR to update the tutorial documentation of the plugin for v1.1 is here: https://github.com/godotengine/godot-docs/pull/5367

A PR to update the Android IAP demo for v1.1 of the plugin is here: https://github.com/godotengine/godot-demo-projects/pull/659

natetrost commented 2 years ago

Bumping this to note a new PR #29 with a minor feature addition and that the Releases needs an update to 1.1.1 so I can get the docs and sample PRs submitted.

slabgames commented 2 years ago 
java.lang.RuntimeException: Unable to resume activity {com.mycompany.cpr/com.godot.game.GodotApp}: java.lang.IllegalArgumentException: Signal billing_resume is not registered for this plugin.

I'm getting this error when running on device. Anyone getting this issue as well?

edit : I think there has been an unapproved PR for this : https://github.com/godotengine/godot-google-play-billing/pull/30

SnailRabbids commented 2 years ago

@natetrost Hi, still in progress? After 2 months, PBL v3 will no longer be supported.

natetrost commented 2 years ago

The relevant PRs have all been merged into the repo to use v4. The prebuilt release is still an old version, but I don't have the ability to update that. But if you build the plugin from source at the current head you should be good to go.

SnailRabbids commented 2 years ago

@natetrost Mb we could tag (@) someone and ask to create new release?

timoschwarzer commented 2 years ago

Please see https://github.com/godotengine/godot-google-play-billing/issues/35