search

godot-sdk-integrations / godot-google-play-billing

Godot Android plugin for the Google Play Billing library
MIT License
160 stars 50 forks source link

Google Play Billing Library: Update from v5.2.1 to v7.0.0 #67

Open kus04e4ek opened 5 months ago

kus04e4ek commented 5 months ago

This PR only partially supersedes them, because it doesn't change Android SDK versions, gradle versions, etc. Also doesn't change already deprecated methods in version 5.

Don't have a Google Play dev account, so can't really test, can just confirm that it compiles and doesn't produce different results when using the iap demo project without Google Play Console (GodotGooglePlayBilling's only compatible with 4.0 versions and maybe some 4.1 versions, tested with 4.0.4).

With this PR docs need to be updated (change BillingFlowParams.ProrationMode to BillingFlowParams.SubscriptionUpdateParams.ReplacementMode).

This PR also makes price_change_acknowledged never emit, API changed a lot. These changes seem too big to test without Google Play Console, so if anyone wants to salvage this PR, feel free. Can be merged as is, of course after testing, if having price_change_acknowledged is not critical.

ivanfemia commented 4 months ago

"At least 1 approving review is required by reviewers with write access." What is missing to have this in the official repo? Who should give the additional review?

kyoz commented 4 months ago

Tested on my production games, work fine. Please release it when possible. ❤️

owlnewworlds commented 4 months ago

What's the state of the issue ? A lot of Godot Android devs are blocked / scared about that. Thank you! <3

ivanfemia commented 4 months ago

. This is not intended to override the official plugin but just a quick temporary solution.

I created a new fork in the meantime with all the fixes You just need to build the project with your Godot libs version.

owlnewworlds commented 4 months ago

. This is not intended to override the official plugin but just a quick temporary solution.

I created a new fork in the meantime with all the fixes You just need to build the project with your Godot libs version.

Thank you! Well I still have time to wait for the official lib to be fixed but I hope it will be ASAP :)

timoschwarzer commented 4 months ago

Sorry people, I'm currently loaded with work so I don't have time to get to this in the next 2 weeks at least. I'll try to review, merge and release as soon as possible though. Hope you understand :heart:

owlnewworlds commented 4 months ago

Sorry people, I'm currently loaded with work so I don't have time to get to this in the next 2 weeks at least. I'll try to review, merge and release as soon as possible though. Hope you understand ❤️

Of course we understand! ^^ Limit date is August 31 if I understood correctly so you have time :)

MarcosFGS-CDS commented 3 months ago

Hello, do we have any updates on this PR? 31 is getting closer every day, regardless any recommendation from the team about how to proceed for new projects until this is approved? thanks

owlnewworlds commented 3 months ago

Hello, do we have any updates on this PR? 31 is getting closer every day, regardless any recommendation from the team about how to proceed for new projects until this is approved? thanks

Same here. Time flies 😅 and I don't want my future builds to be blocked by Google because of that.

MarcosFGS-CDS commented 3 months ago

@timoschwarzer would you be able to provide an ETA for this to be reviewed and released? If this is not possible @kus04e4ek would you be able to provide some help on how to build your fork? I keep getting gradle errors

Thank you in advance

kus04e4ek commented 3 months ago

Would you be able to provide some help on how to build your fork? I keep getting gradle errors

Are you getting General error during semantic analysis: Unsupported class file major version? Then you need to install 14th version of Java and set your JAVA_HOME variable

timoschwarzer commented 3 months ago

@timoschwarzer would you be able to provide an ETA for this to be reviewed and released? If this is not possible @kus04e4ek would you be able to provide some help on how to build your fork? I keep getting gradle

@MarcosFGS-CDS I am not

Yolwoocle commented 2 months ago

Any plans to merge this soon? The 31st august deadline has passed and I'm planning to release a game using this library. The last release is from a year ago...

LMSSonos commented 1 month ago

. This is not intended to override the official plugin but just a quick temporary solution.

I created a new fork in the meantime with all the fixes You just need to build the project with your Godot libs version.

@ivanfemia thanks for the fork. works as expected, only problem I have is that after calling payment.acknowledgePurchase() I get the purchase_acknowledged and purchase_acknowledgement_error events fired with the same token. Any idea?

Edit: I think it was related to the payment.billing_resume which is used according the official documentation, if I remove that and use the purchases_updated only, then it works as expected.