search

godot-sdk-integrations / godot-google-play-billing

Godot Android plugin for the Google Play Billing library
MIT License
156 stars 50 forks source link

Crash after calling an invalid SKU as the argument #9

Closed MightyPrinny closed 4 years ago

MightyPrinny commented 4 years ago

"android.test.canceled" is supposed to simulate a canceled purchase, I can use "android.test.purchased" to test purchases just fine, maybe "android.test.canceled" only works with the old billing API but It would be nice if the game didn't crash or at least an error message was printed to make the reason why the game crashed more clear.

MightyPrinny commented 4 years ago

This looks very similar https://github.com/dooboolab/react-native-iap/issues/386

MightyPrinny commented 4 years ago

"android.test.canceled" works, the crash was my fault, but I'll keep this open because there aren't any error messages when you call purchase with an SKU that doesn't exist or if you call it before querySkuDetails succeeds.

timoschwarzer commented 4 years ago

@MightyPrinny The error is broken in the current release. It's already fixed on master through. I'll make a new release soon.