godotengine / FBX2glTF

A command-line tool for the conversion of 3D model assets on the FBX file format to the glTF file format.
Other
311 stars 73 forks source link

Investigate removing dependency on MSVC redistributable on Windows #11

Closed Calinou closed 2 years ago

Calinou commented 2 years ago

The README says:

FBX2glTF.exe is for Windows. REQUIRES MVSC redistributable on Windows https://support.microsoft.com/en-ca/help/2977003/the-latest-supported-visual-c-downloads

We should investigate removing this requirement to make installation easier, especially in automated scenarios. I see two ways to do this:

Godot itself does not require the MSVC redistributable installed, so it would be good to not have fbx2gltf require it either.

Of course, the above points are moot if the FBX SDK itself requires the MSVC redistributable with no way to work around this.

For now, the README should mention the MSVC redistributable version that is expected by the executable, as newer redistributables are not compatible with executables linked against older versions (and vice versa). Is fbx2gltf built with MSVC 2019 or 2022 on GitHub Actions?

fire commented 2 years ago

The FBX SDK itself requires the MSVC redistributable with no way to work around this.

I think this is the problem.

fire commented 2 years ago
jobs:
  build-win-10:
    runs-on: windows-2019

Here's what it is from CICD.

fire commented 2 years ago

I don't have any good approaches for this. Will close. Comment if you have an idea.