godotengine / FBX2glTF

A command-line tool for the conversion of 3D model assets on the FBX file format to the glTF file format.
Other
338 stars 89 forks source link

Sign and notarize macOS workflow artifact #50

Closed valentinegb closed 7 months ago

valentinegb commented 9 months ago

This pull request aims to integrate signing and notarization into the macOS portion of the build workflow. It has been created before it is ready to be merged because this is something I can't test on my local machine and so heavy review is necessary.

The changes made require new GitHub secrets to be created. They are as follows:

Before approving the workflow for this pull request, remember that it will certainly fail unless these GitHub secrets have been properly set.

This GitHub Docs page was used for reference.

fire commented 9 months ago

I'll get to this when I can. I don't think today is the day :(

valentinegb commented 9 months ago

I'll get to this when I can. I don't think today is the day :(

Not a problem ^^

fire commented 9 months ago

So to be clear I get an apple developer account, get the key in a text form, and put it into the secrets section?

valentinegb commented 9 months ago

I'm not familiar with the Apple Developer dashboard interface, but I think you can download a certificate. Then use the commands I provided to encode it and copy it as text to your clipboard.

valentinegb commented 9 months ago

This article may be helpful: https://developer.apple.com/help/account/create-certificates/create-developer-id-certificates/

valentinegb commented 9 months ago

From various sources online it looks like you can import the .cert file from that article into Keychain and export a .p12 file

fire commented 9 months ago

The other update affected this pull request.

fire commented 8 months ago

@Ughuuu has been helping me get signing into Godot Engine. Can you advise?

valentinegb commented 7 months ago

Hey, sorry it's been a while, I had to completely wipe my computer a while ago and to be honest I totally forgot about this pull request ^^' I'm a bit busy with some other projects now unfortunately but I'll leave all my code up in case someone else wants to pick this back up I may work on this again in the future, but not now, sorry

Ughuuu commented 7 months ago

Made a godot-cpp-template fork with sign action, borrowed from mihe. You could reuse that if the artifact is a .framework.