godotengine / FBX2glTF

A command-line tool for the conversion of 3D model assets on the FBX file format to the glTF file format.
Other
338 stars 89 forks source link

Don't write buffers section if buffer is empty #59

Open danwillm opened 3 months ago

danwillm commented 3 months ago

I have an fbx file that when procced through FBX2gLTF produced the buffers json segment as:

"buffers": [
{
"byteLength": 0
}
],

Which is not valid in gltf. Instead, omit this from being written to the file by only writing non-empty json.

danwillm commented 2 months ago

Hey, anything else you'd like me to resolve for this to be merged?

fire commented 2 months ago

I haven't had much testing of this since in Godot 4.3 we switched to ufbx. I'll merge and it'll generate builds.