search

godotengine / emacs-gdscript-mode

An Emacs package to get GDScript support and syntax highlighting.
GNU General Public License v3.0
306 stars 33 forks source link

Lots of "unknown notification" errors #107

Open LennyPhoenix opened 3 years ago

LennyPhoenix commented 3 years ago

When performing actions such as opening new files, and closing buffers I get errors like this: image

I have the workaround in my emacs config, but it doesn't seem to do anything: image

Any ideas on what I can do? Let me know if I need to send more logs/details.

NathanLovato commented 3 years ago

It's a known issue, seems it could an unsupported command on lsp's side. Not sure exactly. It's not something we can fix directly in gdscript-mode. See https://github.com/emacs-lsp/lsp-mode/issues/2127

The workaround works for me. An alternative is to suppress warnings for lsp-mode (it'll suppress all warnings) (setq warning-suppress-types '((lsp-mode)))

LennyPhoenix commented 3 years ago

Ah I see, I'll try out that workaround then. Thanks :+1:

NathanLovato commented 1 year ago

Is this error still relevant today, about 18 months later?

xiliuya commented 1 year ago

Hello ,@LennyPhoenix emacs already has eglot built in. We have now added the relevant configuration of eglot, I tried to test 'godot 3.5' and it works. If the problem persists with lsp-mode, please try using eglot. Add the following configuration:

(setq gdscript-godot-executable "/home/xiliuya/soft/Godot_v3.5-stable_x11.64"
      gdscript-eglot-version 3)
LennyPhoenix commented 1 year ago

Sorry, I haven't used Emacs in about 2 years so I can't test this anymore sadly.

pivaldi commented 6 days ago

The workaround works for me. An alternative is to suppress warnings for lsp-mode (it'll suppress all warnings) (setq warning-suppress-types '((lsp-mode)))

Disabling all lsp-mode waning you lose important feed-backs. So I create an advise to filter the Emacs warning by string regexp.