refactored sqldump - Githubissues

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library

https://godotengine.org/asset-library

MIT License

292 stars 87 forks source link

refactored sqldump #168

Closed brunosxs closed 5 years ago

brunosxs commented 5 years ago

Ran the scripts in the following order: sqldump and migration-1.sql through 5
Used adminer v4.7.0 and Mysql 8.0.13 in docker to recreate test and generate the sql dump
added an update.sql with the ALTER TABLE commands to add indexes

bojidar-bg commented 5 years ago

I'm not sure we want to remove old migrations. Also, why are indices in a separate .sql file?

brunosxs commented 5 years ago

Sorry then, I'll ask in IRC to see what can be done about the refactoring. I thought, wrongly, that it would be better to remove the multiple sql files and leave just one for the create and other for update.

Em sex, 11 de jan de 2019 11:12, Bojidar Marinov <notifications@github.com escreveu:

I'm not sure we want to remove old migrations. Also, why are indices in a separate .sql file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/godotengine/godot-asset-library/pull/168#issuecomment-453512508, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfFj3fhIF1-3_zTlMLPoKCBUrA7WHJlks5vCI2_gaJpZM4Z7bFJ .

bojidar-bg commented 5 years ago

@brunosxs Well, migrations are updates, what is needed is just the data dump to be latest version. That way, people on old versions can update to the new one, while people who just installed the project can fast-forward to the newest version. Potentially, you can leave the old sql dump as migration-0.sql, then have the rest (1-~6), and finally a data.sql, which maintainers will have to keep in sync. WDYT?

brunosxs commented 5 years ago

Perfect! I'll do that ASAP and amend the commit.

bojidar-bg commented 5 years ago

Looks good, going to merge :smiley:

brunosxs commented 5 years ago

I'll see if I can fix some other stuff, I'll ask to please, bear with my lack of experience with the github workflow and I work alone most of the time. Thanks :)