godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library
https://godotengine.org/asset-library
MIT License
291 stars 86 forks source link

Remove Order By: Cost #191

Closed menip closed 3 years ago

menip commented 4 years ago

Some confusion on my part: I was under the impression that all assets on official Godot Asset Lib have to be free. However, there is option to sort by cost: https://godotengine.org/asset-library/asset?sort=cost

Are paid assets gonna be allowed on official asset lib?

bojidar-bg commented 4 years ago

Cost is actually License. This should be fixed in the frontend.

Burnsedia commented 4 years ago

I can fix that!

Calinou commented 4 years ago

@Burnsedia I think this is just about renaming Cost to License in the frontend (without renaming the query parameter to preserve compatibility).

Burnsedia commented 4 years ago

Ok

On Mon, Mar 30, 2020, 6:04 AM Hugo Locurcio notifications@github.com wrote:

@Burnsedia https://github.com/Burnsedia I think this is just about renaming Cost to License in the frontend (without renaming the query parameter to preserve compatibility).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/godotengine/godot-asset-library/issues/191#issuecomment-605906965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH4ZR57U7AQQXXC7V3LUSSLRKBVDVANCNFSM4ITB57GA .

menip commented 3 years ago

This hasn't been fixed yet. However, I see this repo is now in maintainance only mode. Additionally, the new Godot asset library seems to not have this issues, as seen here.

Should this issue be closed, or just wait for repo to get archived?

Calinou commented 3 years ago

Should this issue be closed, or just wait for repo to get archived?

We should still aim to fix this on the current asset library if we can :slightly_smiling_face: