search

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library
https://godotengine.org/asset-library
MIT License
291 stars 86 forks source link

#34 Update _footer.phtml with change password link. #199

Closed ryneandal closed 4 years ago

ryneandal commented 4 years ago

Added a change password link to the footer template. Resolves #139.

Calinou commented 4 years ago

Placing the change password link besides all other links might be confusing for users. It'll also be difficult to notice. What about placing it on the left side instead (in the area highlighted in red)?

Footer

ryneandal commented 4 years ago

Sounds good. I'll push that up shortly. Thanks,

Ryne Andal

On Tue, Jan 14, 2020 at 10:04 AM Hugo Locurcio notifications@github.com wrote:

Placing the link besides all other links might be confusing for users. What about placing it on the left side instead (in the highlighted area)?

[image: Footer] https://user-images.githubusercontent.com/180032/72360234-f5f85e00-36ef-11ea-82e9-f7ee75aa14ac.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/godotengine/godot-asset-library/pull/199?email_source=notifications&email_token=AAOTQW55SD2M2AL6QY4FOO3Q5XPCFA5CNFSM4KGVAX32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI5FALY#issuecomment-574246959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOTQW5HTTYM4ILAKLUTWZDQ5XPCFANCNFSM4KGVAX3Q .

ryneandal commented 4 years ago

It's now showing on the left side of the footer. image

Calinou commented 4 years ago

This looks better, but the Change Password link should only be displayed if the user is logged in. To achieve this, you could copy the logic used for the navigation bar display (the part with the Logout button).

ryneandal commented 4 years ago

Sure, sorry I didn't consider use case there. Still acclimating myself to the project.