search

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library
https://godotengine.org/asset-library
MIT License
291 stars 86 forks source link

framagit.org not being recognised as gitlab #208

Closed njean42 closed 4 years ago

njean42 commented 4 years ago

I'm trying to submit a game project to the Godot assets lib. The repository URL is https://framagit.org/nicooo/shpactris But I get the following message upon submission:

Error: Due to spam problems, we have to reject your asset because: "https://framagit.org/nicooo/shpactris" might not be correct; it should be similar to "https://gitlab.com//", unless the asset is hosted on a custom instance of GitLab. Please, doublecheck that the URL and the repository provider are correct.

Framagit is a custom instance of GitLab :) Not sure what causes the error.

akien-mga commented 4 years ago

It's currently hardcoded to support only gitlab.com, but that's an unnecessary restriction IMO. The design intent was to support self-hosted instances too. https://github.com/godotengine/godot-asset-library/blob/bae0305f3bca5c524bf80d6ba54c505d8133b1fb/src/Helpers/Utils.php#L31-L37

See also https://github.com/godotengine/godot-asset-library/commit/bae0305f3bca5c524bf80d6ba54c505d8133b1fb#commitcomment-37371587

njean42 commented 4 years ago

Thank you very much for fixing! I could upload a new asset just now. :) The warning message seems pretty good to me, too.