Can't use commit tags instead of a commit hash in submit asset/edit form

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library

https://godotengine.org/asset-library

MIT License

291 stars 86 forks source link

Can't use commit tags instead of a commit hash in submit asset/edit form #214

Closed MightyPrinny closed 4 years ago

MightyPrinny commented 4 years ago

Before I could use a tag such as "0.9.8", but now I get an error message saying I need to match the requested format.

Calinou commented 4 years ago

I think this was intentionally done by @bojidar-bg, as Git tags aren't guaranteed to stay consistent over time (they can be force-pushed, which will make the underlying content change). To do this with a commit hash, you'd have to bruteforce a SHA-1 hash, which is not exactly trivial yet :slightly_smiling_face:

MightyPrinny commented 4 years ago

I think they forgot to change the hint text, it still mentions tag names.

bojidar-bg commented 4 years ago

In fact, I changed the hint text, just forgot to remove the reference to tags from it: https://github.com/godotengine/godot-asset-library/commit/afc9fc8c186878147f4df6206926ca33bb289971#diff-46f650664be62446eb403c311b156359L174.

Anyway, fixed now.