search

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library
https://godotengine.org/asset-library
MIT License
291 stars 86 forks source link

Unable to find Gut #232

Closed CitrusWire closed 3 years ago

CitrusWire commented 3 years ago

If I search for either "test" or "testing" on the asset library it doesn't find Gut.

https://godotengine.org/asset-library/asset?category=&godot_version=&sort=updated&filter=test

https://godotengine.org/asset-library/asset?category=&godot_version=&sort=updated&filter=testing

This despite the fact "testing" and "tests" is in the Gut description: https://godotengine.org/asset-library/asset/54

Calinou commented 3 years ago

The asset library search only works on titles. It's not a full-text search on descriptions, presumably for performance reasons.

The new asset library will allow developers to add one-line blurbs and tags, which will improve assets' searchability significantly.

In the meantime, I changed Gut's name to make it easier to find.

CitrusWire commented 3 years ago

It's not a full-text search on descriptions, presumably for performance reasons.

While I may not know C(++), I'm very proficient with both databases and searching so this I can comment on. :-)

It shouldn't be a performance issue at all; simply index the description field and then simply add to the assets query:

                OR description LIKE :filter

... Although I see no indexes at all are being used(!). Something to add for the new one you mention.

Thanks for the interim fix.