search

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library
https://godotengine.org/asset-library
MIT License
292 stars 94 forks source link

Submodule support? #252

Closed rakkarage closed 2 years ago

rakkarage commented 2 years ago

Will it ever be possible to add projects with submodules?

It seems like it is possible to create a complete release using actions or command line. Or like itch let us upload our own zip with an api?

https://stackoverflow.com/questions/14783127/git-archive-export-with-submodules-git-archive-all-recursive

git archive -o release.zip HEAD
git submodule --quiet foreach 'cd $toplevel; zip -ru release.zip $sm_path'

idk... thanks.

Calinou commented 2 years ago

See also https://github.com/godotengine/godot-proposals/issues/554.

Git submodules suffer from many usability issues and are not included in automatically generated ZIP archives, so they will probably never be supported by GitHub unless you manually create GitHub releases (which is too cumbersome for most users to do).

It is possible for moderators on the asset library to use custom download URLs (so you can point to GitHub Releases), but this is not available for regular users yet. Since asset submissions and edits require approval, I guess it's fine to allow anyone to use custom download URLs.

Edit: Pull request opened: https://github.com/godotengine/godot-asset-library/pull/253