search

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library
https://godotengine.org/asset-library
MIT License
285 stars 85 forks source link

Placeholder fix for mod form on edited assets #277

Closed Gramps closed 1 year ago

Gramps commented 1 year ago

This is a placeholder fix using blank space and a little CSS to pad out the moderation form when approving / rejecting updated assets. Since there is no input field in the accept form to pad the form out, it kind of collapses.

There is also a Twig and PHP version addition to the composer.json; part of my replacing the current templating with Twig for better readability of template files. These can be omitted currently but shouldn't hurt anything.

coppolaemilio commented 1 year ago

I wouldn't want to merge this if Twig is not being used yet. Since we already discussed that we should remove bower, if you can remove it form this PR and create another one adding Twig and removing bower I think it would be better.

Gramps commented 1 year ago

Can do, cap'n! Just close this one and I'll pull those out then resubmit.

Gramps commented 1 year ago

Also, should I hardcode the paths to the files Bower includes? It is basically pulling in Bootstrap and JQuery which can just be added directly.

coppolaemilio commented 1 year ago

yeah, you can hardcode the paths 👍 closing!