godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library
https://godotengine.org/asset-library
MIT License
292 stars 94 forks source link

View files not pointing to specified commit #312

Open moritztim opened 10 months ago

moritztim commented 10 months ago

Clicking View Files should not lead to https://github.com/{user}/{repo} but to the state of the repo at the specified commit https://github.com/{user}/{repo}/tree/{hash} otherwise there might be a readme that was made for a newer version or other unaproved changes to files, which the user might end up downloading from github, thinking they must have been approved. Being able to optionally specify a tag instead of a commit hash would of course be even nicer:

image

Calinou commented 10 months ago

The URL to use to view the repository at the state of a commit is of the form https://github.com/{user}/{repo}/tree/{hash} (tree rather than commit).

moritztim commented 10 months ago

Right