Prevent multiple edits of the same asset by the same user

godotengine / godot-asset-library

PHP frontend for Godot Engine's asset library

https://godotengine.org/asset-library

MIT License

292 stars 87 forks source link

Prevent multiple edits of the same asset by the same user #71

Open akien-mga opened 7 years ago

akien-mga commented 7 years ago

Even though I feel the UX is not too bad right now, we still get duplicate edits of some assets and I spend my time having to reject them:

It would be nice to:

show more prominently to users that they have one pending edit for the asset they want to re-edit
if they want to go to the edit form for an asset with a pending edit, they should be notified about it and redirected to the revise form of the pending edit

RodZill4 commented 7 years ago

I'm afraid you will have to reject https://godotengine.org/asset-library/asset/edit/114 as well, sorry for that.

When submitting the asset for the first time, I got an error (missing thumbnail for a video) and assumed submission had failed. I filled the form again and then realized I had 2 pending assets.

Is there a way of deleting a pending asset ?

akien-mga commented 7 years ago

Is there a way of deleting a pending asset ?

Don't worry, we can just reject the edit as I did (with motive that it's the duplicate of a later, more complete edit).

akien-mga commented 7 years ago

This should also be implemented for edits of new assets, i.e. "Create blabla" submissions. It should not be allowed to issue several such submissions, users should instead be forced to revise their initial submit.

bojidar-bg commented 7 years ago

@akien-mga Thats not a hard thing, since new assets are considered as edits of asset -1 :smile:

akien-mga commented 7 years ago

Hehe, so users wouldn't be allowed to submit two different new assets? ;)

brandonlamb commented 7 years ago

Just coming across this after I posted a bug report. I found it difficult to understand the current user flow with edits.

Maybe some kind of draft system needed, or ability to create versions, or whatever other brilliant solution can be had. Right now the current flow is confusing (to me).

akien-mga commented 7 years ago

Bump, this is slowly getting quite annoying:

akien-mga commented 7 years ago

Every time I've made edits I've found the system pretty clear that the edit is awaiting moderation and can be further "revised" if need be, but somehow people always create new edits. So preventing multiple edits on the same assets would really go a long way to enforce the workflow that was intended.