search

godotengine / godot-cpp-template

Quickstart template for GDExtension development with Godot
https://docs.godotengine.org/en/stable/tutorials/scripting/gdextension/what_is_gdextension.html
The Unlicense
145 stars 55 forks source link

Remove unneeded godot-cpp build step from the GitHub action. #63

Closed Ivorforce closed 2 weeks ago

Ivorforce commented 2 weeks ago

Briefly discussed on Rocket Chat, it seems this is wholly just not needed for the runner, as godot-cpp is built as part of the GDExtension build step.

I know some repositories suggest building the deps first and the project later, using separate caches for each such that a rebuild can go faster. But as far as I've seen, in this project it doesn't work because the later build step just re-builds godot-cpp from scratch anyhow (at least for me). If anybody's seen evidence to the contrary, please share them.

Ivorforce commented 2 weeks ago

Paging @Ughuuu because this PR would remove the option d100b72a3a1017ce2bebbe2d23b4c0fab6158a92 just added.

paddy-exe commented 2 weeks ago

Looks good to me. However will wait for others to approve as well before merging.

Ivorforce commented 2 weeks ago

Yes, we should definitely have someone else test the builds on this branch before merging.

Ughuuu commented 2 weeks ago

Looks good, will remove then in my build again, np. Haven't tested it yet but I think it should work. Will test after it gets merged.

paddy-exe commented 2 weeks ago

Thanks for the quick PR @Ivorforce