search

godotengine / godot-cpp-template

Quickstart template for GDExtension development with Godot
https://docs.godotengine.org/en/stable/tutorials/scripting/gdextension/what_is_gdextension.html
The Unlicense
145 stars 55 forks source link

Fix formatting of `compatibility_minimum` #8

Closed AThousandShips closed 1 year ago

AThousandShips commented 1 year ago

Without quotes the values is parsed as a float, breaking in various cases.

paddy-exe commented 1 year ago

Looks great. Thanks for the PR!

paddy-exe commented 1 year ago

@dsnopek Could you let me know when the connected godot-cpp PR was cherry-picked to 4.1?

dsnopek commented 1 year ago

I've just created the cherrypick PR https://github.com/godotengine/godot-cpp/pull/1227 which you can keep an eye on

paddy-exe commented 1 year ago

Merged, thanks @AThousandShips 🎉

AThousandShips commented 1 year ago

Thank you!