godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.7k stars 528 forks source link

miss argument #1421

Closed GraCoder closed 6 months ago

GraCoder commented 6 months ago

UtilityFunctions::instance_from_id crash

AThousandShips commented 6 months ago

I think the solution is instead to change this https://github.com/godotengine/godot-cpp/blob/a62f633cebee4b36356dc903d00670733cd28fb1/binding_generator.py#L2054

To:

function_call += "internal::_call_utility_ret_obj(_gde_function, nullptr"

Like this: https://github.com/godotengine/godot-cpp/blob/a62f633cebee4b36356dc903d00670733cd28fb1/binding_generator.py#L1774

AThousandShips commented 6 months ago

Made a fix for this by removing the argument from the method entirely as it's never used and isn't depended on, will open a PR