search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.74k stars 575 forks source link

Fix incorrect utility call signature #1422

Closed AThousandShips closed 7 months ago

AThousandShips commented 7 months ago

The alternative method would be to change the bindings from: https://github.com/godotengine/godot-cpp/blob/a62f633cebee4b36356dc903d00670733cd28fb1/binding_generator.py#L2054

To:

function_call += "internal::_call_utility_ret_obj(_gde_function, nullptr"

But I don't see any reason to pass this argument here, and this is strictly internal, so I think this is the simplest and cleanest solution, I have tested both methods and they both work correctly

See:

dsnopek commented 7 months ago

Ack, there's a conflict now from merging PR https://github.com/godotengine/godot-cpp/pull/1409. Can you please rebase it? Thanks!

dsnopek commented 7 months ago

Thanks!

AThousandShips commented 7 months ago

Thank you!

dsnopek commented 7 months ago

Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1411

dsnopek commented 7 months ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1410