is_finite function missing from Basis, Vector2, Vector3, etc.(about 11 classes should have it)

godotengine / godot-cpp

C++ bindings for the Godot script API

MIT License

1.74k stars 575 forks source link

is_finite function missing from Basis, Vector2, Vector3, etc.(about 11 classes should have it) #1434

Closed Ughuuu closed 6 months ago

Ughuuu commented 7 months ago

Godot version

4.2

godot-cpp version

4.2

System information

mac m1

Issue description

In godot > core/math/basis.h there is bool is_finite() const; In godot-cpp there isn't such a method. I tried to replicate it, but it's also missing on Vector2 and Vector3 and other classes (more can be found in extension_api.json file with all places it should be).

Steps to reproduce

Minimal reproduction project

dsnopek commented 7 months ago

Thanks!

Given that Vector2, Vector3, Basis and other variant types are re-implemented in godot-cpp (as opposed to using bound methods), this will probably need to just be copied into godot-cpp from the original Godot implementation.

AThousandShips commented 7 months ago

I'll write up a transfer PR tomorrow for these classes syncing them

Ughuuu commented 7 months ago

Perfect, thanks, initially I wanted to do a PR but there seems to be a bit of work to do.