search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.69k stars 527 forks source link

Godot-cpp fails to generate vsproj when vsproj=yes. command is ignored #1470

Closed jak6jak closed 3 months ago

jak6jak commented 4 months ago

Godot version

daa81bb

godot-cpp version

b697ba8

System information

Windows 11

Issue description

When building godot-cpp or the recommended template inside the readme it fails to recognize the vsproj=yes command. I get the following error: WARNING: Unknown SCons variables were passed and will be ignored: vsproj=yes the build succeeds but is unable to generate vsproj.

Steps to reproduce

  1. clone godot-cpp or godot-cpp template: https://github.com/godotengine/godot-cpp-template
  2. Run command scons vsproj=yes
  3. Observe that the build is successfully but without generating vsproj

Minimal reproduction project

N/A

AThousandShips commented 4 months ago

There's no such option for godot-cpp, just for Godot itself, so this would be proposing a new feature

See https://github.com/godotengine/godot-cpp/issues/1071#issuecomment-1475408828

dsnopek commented 3 months ago

I'm going to go ahead and close this one. As pointed out on the linked comment, since godot-cpp supports cmake, it probably makes more sense to use cmake to generate a Visual Studio project. If folks really think we need this as a scons feature, then they can open a new issue