Closed richardhozak closed 3 months ago
These are valid changes generally but more generally we don't necessarily support building with every possible warning setting, so any future niche errors that might be fired by a setting we don't have as part of our build setup might not be as appropriate, though again in this case they should be valid
Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1491
Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1492
Hello, I am tracking 4.2 branch of godot-cpp for my project and compiling my whole project with -Wall. I recently updated godot-cpp to pull all changes from 4.2 branch and there are some new warnings during build that this PR fixes.
The warnings that are fixed by this are:
The first two are just changing the int type to match the one on right hand side and the third one is just what gcc suggested.