Fix sharing of typed arrays from constructor

godotengine / godot-cpp

C++ bindings for the Godot script API

MIT License

1.69k stars 528 forks source link

Fix sharing of typed arrays from constructor #1483

Closed AThousandShips closed 3 months ago

AThousandShips commented 3 months ago

See:

https://github.com/godotengine/godot/pull/89197

Doesn't depend on the engine fix beyond approval of the approach, so if it looks good for this side I'm open for it being merged here first (only the compatibility expectations to consider)

Closes: https://github.com/godotengine/godot-cpp/issues/1149

dsnopek commented 3 months ago

Thanks!

I think I'd prefer to wait until the Godot PR is merged first, because that'll mean the approach has gotten review from folks who understand this code better than me. :-)

TokisanGames commented 3 months ago

This PR fixes an issue with TypedArrays duplicating when retrieved from dictionaries #1508 with the official Godot 4.2.2-stable engine.

dsnopek commented 2 months ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1527

dsnopek commented 2 months ago

Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1529