search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.69k stars 528 forks source link

Fix vararg methods forwarded to the `ClassDB` singleton #1485

Closed dsnopek closed 3 months ago

dsnopek commented 3 months ago

Aims to fix the CI issues with Godot PR https://github.com/godotengine/godot/pull/93141 as well as allowing forwarded vararg methods to work.

This will need to be cherry-picked to the 4.2 branch before CI on that PR can pass.

dsnopek commented 3 months ago

PR https://github.com/godotengine/godot-cpp/pull/1486 should fix the test failure - it's unrelated to the changes here

AThousandShips commented 3 months ago

My bad accidentally made my own fix for this, will make that just an improvement and leave this for the immediate fix

dsnopek commented 3 months ago

Thanks for the review!

dsnopek commented 3 months ago

Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1491

dsnopek commented 3 months ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1492