search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.69k stars 528 forks source link

Fix generating default values for `StringName` #1487

Closed AThousandShips closed 3 months ago

AThousandShips commented 3 months ago

Cases other than &"" were not processed correctly

See https://github.com/godotengine/godot/pull/91382#issuecomment-2165890277

AThousandShips commented 3 months ago

I'll make a separate one adding NodePath argument defaults as well as they're missing from this part, but aren't currently used anywhere

AThousandShips commented 3 months ago

Needs cherry-picking for 4.2 for the linked PR to work, so if possible that'd be good to get around

dsnopek commented 3 months ago

Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1491

dsnopek commented 3 months ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1492