search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.69k stars 528 forks source link

Replace generic macros with math equivalents #1503

Open Repiteo opened 3 months ago

Repiteo commented 3 months ago

godot-cpp counterpart to godotengine/godot#91324

As this is already largely implemented on godot-cpp's side already, this isn't technically dependant on the aforementioned PR (though it does lift the internals & constexpr). Rather, this focuses on converting whatever remaining macro instances existed with their math equivalents, and labeling the macros as deprecated.

dsnopek commented 3 months ago

Thanks! This looks good at a first glance :-)

this isn't technically dependant on the aforementioned PR (though it does lift the internals & constexpr)

I'd still prefer to wait until the Godot PR is merged, so that we can be sure this PR is sync'd with the latest version of the code there