search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.74k stars 575 forks source link

Add a test to ensure that library path is absolute #1520

Closed dsnopek closed 2 months ago

dsnopek commented 4 months ago

Two times now we have broken get_library_path such that it doesn't return an absolute path.

See:

This is a Godot issue, but this PR adds a test to CI that will verify that the path is absolute, in order to try and help us not break it again.

This will fail CI until PR https://github.com/godotengine/godot/pull/94373 is merged

dsnopek commented 2 months ago

Whoops! I didn't mean to actually click the merge button on that one. It only adds a test, though, and the test is passing so I think everything will be OK. :-)

dsnopek commented 2 months ago

Cherry-picked for 4.3 in PR https://github.com/godotengine/godot-cpp/pull/1569

dsnopek commented 2 months ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1570