search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.74k stars 575 forks source link

[Web/SCons] Use CCFLAGS for SIDE_MODULE option #1560

Closed Faless closed 2 months ago

Faless commented 2 months ago

Was using CPPFLAGS, but should use the explicit scons CCFLAGS which makes it clear they are applied to both the C and C++ compiler.

CPPFLAGS was also fine (they are preprocessor flags, also applied to both C and C++), but we should try to stay consistent with what we do in Godot.

dsnopek commented 2 months ago

Cherry-picked for 4.3 in PR https://github.com/godotengine/godot-cpp/pull/1569

dsnopek commented 2 months ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1570

dsnopek commented 2 months ago

Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1572