godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.7k stars 525 forks source link

add SYMBOL_VISIBILITY cache variable to match scons interface. #1579

Closed enetheru closed 2 weeks ago

enetheru commented 2 weeks ago

Bring the 'cmake -LH' output inline with the scons output. I dont know what the policy on adding notes in comments are. I can ammend the commit to remove them if they are unwanted.

dsnopek commented 2 weeks ago

Ah, sorry, I didn't notice this when I approved: you need to squash this down to a single commit before I can merge it.

This is part of Godot's development workflow: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request

enetheru commented 2 weeks ago

Apologies, commits have been squashed and I'll remember it for next time.

dsnopek commented 2 weeks ago

Thanks!