search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.74k stars 575 forks source link

[4.3] Revert "Unexpose `UtilityFunctions::is_instance_valid()`" #1592

Closed dsnopek closed 1 month ago

dsnopek commented 2 months ago

This reverts commit 56cd3fd99eb76ca3da33dafb694828a7306b2c81 aka PR https://github.com/godotengine/godot-cpp/pull/1513.

It fixes issue https://github.com/godotengine/godot-cpp/issues/1587 (for Godot 4.3 and earlier), which pointed out that there is a use-case that can't be currently be replicated using ObjectID and ObjectDB.

(See PR https://github.com/godotengine/godot/pull/97119 for a way to keep the removal of UtilityFunctions::is_instance_valid() while still allowing for this use-case, but it will need to be Godot 4.4+)

ashtonmeuser commented 1 month ago

This is still not included in the godot-4.3-stable tag. No rush, but I'm curious to know the process for bumping stable tags.

dsnopek commented 2 weeks ago

@ashtonmeuser We currently do godot-cpp releases at the same time as Godot releases, so it'll end up in 4.3.1