search

godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.75k stars 577 forks source link

[SCons] Remove use_clang_cl windows flag in favor of generic use_llvm #1602

Closed Faless closed 1 month ago

Faless commented 2 months ago

This is consistent with Godot upstream.

As discussed in https://github.com/godotengine/godot-cpp/pull/1601#discussion_r1770526612 it seems that we have a discrepancy between upstream Godot and godot-cpp which uses a special use_clang_cl instead of the generic use_llvm flag for building Windows with the clang MSVC backend.

dsnopek commented 3 weeks ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1631

dsnopek commented 3 weeks ago

Cherry-picked for 4.3 in PR https://github.com/godotengine/godot-cpp/pull/1632