Rename Vector4.components -> coords.

godotengine / godot-cpp

C++ bindings for the Godot script API

MIT License

1.7k stars 525 forks source link

Rename Vector4.components -> coords. #1609

Open Ivorforce opened 3 days ago

Ivorforce commented 3 days ago

Follow-up of https://github.com/godotengine/godot/pull/97487#pullrequestreview-2331113052 Fixes #1608

As mentioned, a discussion could be had about just removing the 'components' alias, but I think there's no harm just using deprecations as is usually done.

AThousandShips commented 3 days ago

Should be made in the same PR, ether we add compatibility or we don't, it should be decided and done in one PR

Ivorforce commented 3 days ago

Yes, in the current state of the PR the 'components' union case is retained, with a deprecation note.

Ivorforce commented 3 days ago

Parent PR is merged, so we're good to go.