godotengine / godot-csharp-vscode

Debugger and utilities for working with Godot C# projects in VSCode
https://marketplace.visualstudio.com/items?itemName=neikeq.godot-csharp-vscode
MIT License
145 stars 27 forks source link

executableArguments are being ignored #19

Closed Twofour2 closed 3 years ago

Twofour2 commented 3 years ago

The following launch configuration should cause godot to immediately quit by passing the -q switch, however all of the executable arguments appear to be unused by this extension.

  "type": "godot-mono",
  "request": "launch",
  "mode": "executable",
  "executable": "${workspaceRoot}/Godot.exe",
  "executableArguments": [
      "--path",
      "${workspaceRoot}",
      "-q"
  ]
raulsntos commented 3 years ago

It seems the arguments passed to the executable are specified here:

https://github.com/godotengine/godot-csharp-vscode/blob/d6cb2f0c05f4bb17616c81d7934b5b6c77d00ebb/GodotDebugSession/GodotDebuggerSession.cs#L94

GodotDebugSession gets the executable argument but it doesn't look like it ever gets the executableArguments anywhere.

https://github.com/godotengine/godot-csharp-vscode/blob/d6cb2f0c05f4bb17616c81d7934b5b6c77d00ebb/GodotDebugSession/GodotDebugSession.cs#L87