Use executableArguments when launching the Godot process with MedallionShell

godotengine / godot-csharp-vscode

Debugger and utilities for working with Godot C# projects in VSCode

MIT License

145 stars 27 forks source link

Closed raulsntos closed 3 years ago

raulsntos commented 3 years ago

Re-implements launching the Godot process with https://github.com/madelson/MedallionShell and provides the executableArguments to the command (fixes #19).

MedallionShell handles the escaping of the arguments.

This is an alternative implementation of #20 which should handle more edge cases escaping the arguments.

neikeq commented 3 years ago

LGTM and I'm fine with the dependency. Let me know if it's ready to merge.

raulsntos commented 3 years ago

Yeah, it's ready to merge.

guivieiras commented 3 years ago

@neikeq Can it be merged already?

neikeq commented 3 years ago

Sorry, I forgot about this.