godotengine / godot-demo-projects

Demonstration and Template Projects
https://godotengine.org
MIT License
5.75k stars 1.59k forks source link

Adding different material roughness parameters for easy testing to 3d/material_tests #897

Closed armmah closed 1 year ago

armmah commented 1 year ago

The material tests scene demo has a range of materials currently on display for the demo, but it lacks a grid of abstract materials with specific increments for testing purposes of PBR.

While iterating on SSR I set up this grid that has both dielectrics and metals, and varying roughness value from 1.0 on the left to 0.0 on the right by a 0.1 step (simply duplicating the materials and setting the metal and roughness parameters on it).

image

No changes done to the demo itself, the new platform is outside of the camera frustum when going through the materials in the demo. image

I already have this setup locally and if this can be useful I can open a PR.

Calinou commented 1 year ago

https://github.com/godotengine/godot-demo-projects/pull/809 has a setup with all roughness and metallic levels, but I think it makes sense to add this to the Material Testers demo as well.

Feel free to open a pull request for this :slightly_smiling_face:

No changes done to the demo itself, the new platform is outside of the camera frustum when going through the materials in the demo.

It makes sense to set visible = false on those nodes in _ready(), so that you can see them in the editor but not in the running project (to improve performance on low-end systems).

armmah commented 1 year ago

visible = false added on a separate dedicated script, didn't want to introduce unncessary dependencies on the demo test script.

PR created https://github.com/godotengine/godot-demo-projects/pull/899

Calinou commented 1 year ago