search

godotengine / godot-demo-projects

Demonstration and Template Projects
https://godotengine.org
MIT License
5.74k stars 1.59k forks source link

Fixed websocket_chat demo for Godot 4.0.2 #909

Closed Anutrix closed 1 year ago

Anutrix commented 1 year ago

I made only changes to:

The layout_mode changes in combo.tscn(on first run) as well as changes to project.godot(on opening project) were done automatically by the editor. I kept them since it might simplify the project and didn't break anything. I will remove it if advised.

image No more errors. And everything seems to work fine.

My first MR as part of https://github.com/godotengine/godot-demo-projects/issues/697.

Calinou commented 1 year ago

The layout_mode changes in combo.tscn(on first run) as well as changes to project.godot(on opening project) were done automatically by the editor. I kept them since it might simplify the project and didn't break anything. I will remove it if advised.

Keep those changes in, as they're required for the project to run correctly without changes being made as soon as you open the editor.

Calinou commented 1 year ago

Superseded by https://github.com/godotengine/godot-demo-projects/pull/918. Thanks for the contribution nonetheless!